Assalaam Alaikum Wa Rahmatullah Wa Barkartu
I'm attend for marriage, for over a year now to a brother who has informed me that he still does not have the means to marry right now. How long should I stay attended to him, I've made istahirka and he is a good brother who fears Allah (swt). Should I practice sabr or move on?

All perfect praise be to Allaah, The Lord of the Worlds. I testify that there is none worthy of worship except Allaah, and that Muhammad, sallallaahu ‘alayhi wa sallam, is His Slave and Messenger.

There is no specific period of engagement determined by Sharee‘ah according to the best of our knowledge. It depends here on the mutual consent of both parties of the marital contract, i.e. the husband and the woman's guardian or the rational woman who knows well her benefit. If she or her guardian approves that the period of engagement be long with no harm to be caused to the engaged woman, then it is permissible. But, at the same time, marriage is among the good things which people should hasten. Allaah The Almighty Said (what means): {so race to [all that is] good.}[Quran 5:48]

So, if that suitor is a man of religion and good moral character, then he should be helped in the matter of that marriage by facilitating the dowry for him and the like, for reducing the costs of marriage is among the causes of its blessing. In this respect, it is narrated on the authority of ‘Aa’ishah that the Prophet, sallallaahu ‘alayhi wa sallam, said: "The most blessed among women are those who cost the least (in marriage)." [Ahmad and An-Nasaa’i]

Besides, it should also be learnt that marriage is among the means of increase in sustenance; Allaah The Almighty Said (what means): {And marry the unmarried among you and the righteous among your male slaves and female slaves. If they should be poor, Allaah will Enrich them from His bounty.}[Quran 24:32] It is narrated on the authority of Abu Hurayrah that he said: The Messenger of Allaah, sallallaahu ‘alayhi wa sallam, said: "There are three kinds of people who have the right on Allaah to help them: the Mujaahid (fighter) in the Way of Allaah, the Mukaatab (the slave who has a written deed of emancipation in return for a sum to be paid in installments to his master) who wants freedom, and the one who is going to marry therewith he seeks chastity." [At-Tirmithi and An-Nasaa’i]

On the other hand, if the marriage does not take place and the girl fears that the period of engagement would last for long thus causing her harm, it might be preferable for her to cancel the engagement, given that the engagement is no more than a mutual promise of marriage between both parties, and it is permissible for each of them to cancel it whenever they wish.